zhannngchen commented on code in PR #45279:
URL: https://github.com/apache/doris/pull/45279#discussion_r1879478488
##########
be/src/olap/compaction.cpp:
##########
@@ -986,8 +986,33 @@ Status CompactionMixin::modify_rowsets() {
if
(!_tablet->tablet_meta()->tablet_schema()->cluster_key_uids().empty()) {
merged_missed_rows_size += _stats.filtered_rows;
}
+
+ bool need_to_check_missed_rows = true;
+ {
+ std::shared_lock rlock(_tablet->get_header_lock());
+ need_to_check_missed_rows =
+ std::all_of(_input_rowsets.begin(),
_input_rowsets.end(),
+ [&](const RowsetSharedPtr& rowset) {
+ return
tablet()->rowset_exists_unlocked(rowset);
+ });
+ }
+ if (!need_to_check_missed_rows) {
Review Comment:
don't need such log here, the compaction will fail finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
