github-actions[bot] commented on code in PR #44994:
URL: https://github.com/apache/doris/pull/44994#discussion_r1879312363
##########
be/src/http/action/download_binlog_action.cpp:
##########
@@ -144,8 +144,19 @@ void handle_get_segment_index_file(StorageEngine& engine,
HttpRequest* req,
const auto& rowset_id = get_http_param(req, kRowsetIdParameter);
const auto& segment_index = get_http_param(req,
kSegmentIndexParameter);
const auto& segment_index_id = req->param(kSegmentIndexIdParameter);
- segment_index_file_path =
- tablet->get_segment_index_filepath(rowset_id, segment_index,
segment_index_id);
+ auto segment_file_path = tablet->get_segment_filepath(rowset_id,
segment_index);
+ if (tablet->tablet_schema()->get_inverted_index_storage_format() ==
+ InvertedIndexStorageFormatPB::V1) {
+ // now CCR not support for variant + index v1
+ constexpr std::string_view index_suffix = "";
Review Comment:
warning: redundant string initialization [readability-redundant-string-init]
```suggestion
constexpr std::string_view index_suffix;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
