xzj7019 commented on code in PR #45081:
URL: https://github.com/apache/doris/pull/45081#discussion_r1879219943
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/ExpressionOptimization.java:
##########
@@ -58,6 +59,20 @@ public class ExpressionOptimization extends
ExpressionRewrite {
BetweenToEqual.INSTANCE
)
);
+
+ /**
+ * don't use it with PushDownFilterThroughJoin, it may cause dead loop:
+ * LogicalFilter(origin expr)
+ * => LogicalFilter((origin expr) and (add min max range))
+ * => LogicalFilter((origin expr)) // use PushDownFilterThroughJoin
+ * => ...
+ */
+ public static final List<ExpressionRewriteRule> ADD_RANGE =
ImmutableList.of(
Review Comment:
pls add explain that why splitting this as a separate rule set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
