This is an automated email from the ASF dual-hosted git repository.
jacktengg pushed a commit to branch spill_and_reserve
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 32d78810affd3d7701c3b16c53db947a53f6d787
Author: jacktengg <tengjianp...@selectdb.com>
AuthorDate: Sun Dec 8 23:34:55 2024 +0800
delete unused parameter
---
be/src/runtime/workload_group/workload_group_manager.cpp | 12 ++++++------
be/src/runtime/workload_group/workload_group_manager.h | 3 +--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/be/src/runtime/workload_group/workload_group_manager.cpp
b/be/src/runtime/workload_group/workload_group_manager.cpp
index 558765a04b7..79379f5682e 100644
--- a/be/src/runtime/workload_group/workload_group_manager.cpp
+++ b/be/src/runtime/workload_group/workload_group_manager.cpp
@@ -388,8 +388,8 @@ void WorkloadGroupMgr::handle_paused_queries() {
continue;
}
if (flushed_memtable_bytes <= 0) {
- flushed_memtable_bytes =
flush_memtable_from_current_group_(
- query_ctx, wg, query_it->reserve_size_);
+ flushed_memtable_bytes =
+ flush_memtable_from_current_group_(wg,
query_it->reserve_size_);
}
if (flushed_memtable_bytes > 0) {
// Flushed some memtable, just wait flush finished and not
do anything more.
@@ -455,8 +455,8 @@ void WorkloadGroupMgr::handle_paused_queries() {
if (query_it->cache_ratio_ < 0.001) {
// 1. Check if could revoke some memory from memtable
if (flushed_memtable_bytes <= 0) {
- flushed_memtable_bytes =
flush_memtable_from_current_group_(
- query_ctx, wg, query_it->reserve_size_);
+ flushed_memtable_bytes =
+ flush_memtable_from_current_group_(wg,
query_it->reserve_size_);
}
if (flushed_memtable_bytes > 0) {
// Flushed some memtable, just wait flush finished and
not do anything more.
@@ -521,8 +521,8 @@ void WorkloadGroupMgr::handle_paused_queries() {
}
// Return the expected free bytes if memtable could flush
-int64_t WorkloadGroupMgr::flush_memtable_from_current_group_(
- std::shared_ptr<QueryContext> requestor, WorkloadGroupPtr wg, int64_t
need_free_mem) {
+int64_t WorkloadGroupMgr::flush_memtable_from_current_group_(WorkloadGroupPtr
wg,
+ int64_t
need_free_mem) {
// If there are a lot of memtable memory, then wait them flush finished.
MemTableMemoryLimiter* memtable_limiter =
doris::ExecEnv::GetInstance()->memtable_memory_limiter();
diff --git a/be/src/runtime/workload_group/workload_group_manager.h
b/be/src/runtime/workload_group/workload_group_manager.h
index 8dfc3c5f824..fc53bfea858 100644
--- a/be/src/runtime/workload_group/workload_group_manager.h
+++ b/be/src/runtime/workload_group/workload_group_manager.h
@@ -112,8 +112,7 @@ public:
private:
int64_t cancel_top_query_in_overcommit_group_(int64_t need_free_mem,
int64_t lower_bound,
RuntimeProfile* profile);
- int64_t flush_memtable_from_current_group_(std::shared_ptr<QueryContext>
requestor,
- WorkloadGroupPtr wg, int64_t
need_free_mem);
+ int64_t flush_memtable_from_current_group_(WorkloadGroupPtr wg, int64_t
need_free_mem);
bool handle_single_query_(const std::shared_ptr<QueryContext>& query_ctx,
size_t size_to_reserve, int64_t time_in_queue,
Status paused_reason);
int64_t revoke_memory_from_other_group_(std::shared_ptr<QueryContext>
requestor,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
