yiguolei commented on code in PR #45194:
URL: https://github.com/apache/doris/pull/45194#discussion_r1875802538
##########
regression-test/suites/datatype_p0/ip/test_ip_basic.groovy:
##########
@@ -160,4 +160,11 @@ suite("test_ip_basic") {
qt_sql """ select * from table_ip where col0 = 1"""
sql """ Update table_ip set col25 =
'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff' where col0 = 1 """
qt_sql """ select * from table_ip where col0 = 1"""
+
+ // test ip with default value
+ sql """ DROP TABLE IF EXISTS table_ip_default """
+ sql """ CREATE TABLE IF NOT EXISTS `table_ip_default` (`col0` bigint NOT
NULL, `col4` ipv6 NULL DEFAULT "::", `col24` ipv4 NULL DEFAULT "127.0.0.1")
ENGINE=OLAP UNIQUE KEY(`col0`) DISTRIBUTED BY HASH(`col0`) BUCKETS 4 PROPERTIES
("replication_allocation" = "tag.location.default: 1") """
Review Comment:
add more
test:
1. show create table
2. desc table
3. create table like
to make sure in all cases, the default value is not lost.
##########
regression-test/suites/datatype_p0/ip/test_ip_basic.groovy:
##########
@@ -160,4 +160,11 @@ suite("test_ip_basic") {
qt_sql """ select * from table_ip where col0 = 1"""
sql """ Update table_ip set col25 =
'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff' where col0 = 1 """
qt_sql """ select * from table_ip where col0 = 1"""
+
+ // test ip with default value
+ sql """ DROP TABLE IF EXISTS table_ip_default """
+ sql """ CREATE TABLE IF NOT EXISTS `table_ip_default` (`col0` bigint NOT
NULL, `col4` ipv6 NULL DEFAULT "::", `col24` ipv4 NULL DEFAULT "127.0.0.1")
ENGINE=OLAP UNIQUE KEY(`col0`) DISTRIBUTED BY HASH(`col0`) BUCKETS 4 PROPERTIES
("replication_allocation" = "tag.location.default: 1") """
Review Comment:
add more test:
1. show create table
2. desc table
3. create table like
to make sure in all cases, the default value is not lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
