HappenLee commented on code in PR #44850:
URL: https://github.com/apache/doris/pull/44850#discussion_r1874624114
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -271,14 +285,16 @@ Status ExchangeSinkBuffer::_send_rpc(InstanceLoId id) {
} else if (!s.ok()) {
_failed(id,
fmt::format("exchange req success but status isn't ok:
{}", s.to_string()));
+ return;
} else if (eos) {
_ended(id);
- } else {
- s = _send_rpc(id);
- if (!s) {
- _failed(id, fmt::format("exchange req success but status
isn't ok: {}",
- s.to_string()));
- }
+ }
+ // The eos here only indicates that the current exchange sink has
reached eos.
+ // However, the queue still contains data from other exchange
sinks, so RPCs need to continue being sent.
Review Comment:
if (s.ok() || s.eof()) s = send_rpc(id)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
