liaoxin01 commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r878672704
##########
be/src/vec/columns/column.h:
##########
@@ -183,6 +183,11 @@ class IColumn : public COW<IColumn> {
/// All data will be inserted as single element
virtual void insert_data(const char* pos, size_t length) = 0;
+ // just used for ColumnDecimal to be compatible with decimalv2
+ virtual void insert_many_decimalv2_data(const char* pos, size_t num) {
Review Comment:
This function will be called in bitshuffle_page.h. ColumnDecimal\<T\> is
template class. We don't know the real type of T when the function was called
in bitshuffle_page.h, so we can't use static_cast here.
There are several solutions：
1. use dynamic_cast
2. change insert_many_decimalv2_data to a template function
I don't think they are better than the current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
