englefly commented on code in PR #44748:
URL: https://github.com/apache/doris/pull/44748#discussion_r1862997877
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalProject.java:
##########
@@ -278,4 +278,22 @@ public void computeFd(DataTrait.Builder builder) {
}
}
}
+
+ @Override
+ public Plan replaceExpressions(Map<? extends Expression, ? extends
Expression> replaceMap) {
+ List<NamedExpression> newProjections = new ArrayList<>();
+ boolean changed = false;
+ for (NamedExpression expr : getProjects()) {
+ if (replaceMap.containsKey(expr) && replaceMap.get(expr)
instanceof NamedExpression) {
Review Comment:
yes,only top level. Because we only replace the encode-fun generated by
compress-materialzie rule, which is top level
It will be moved to PushDownEncodeSlot rule, only apply to Logical project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
