zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863787324
##########
be/src/pipeline/exec/operator.cpp:
##########
@@ -398,8 +398,7 @@ std::shared_ptr<BasicSharedState>
DataSinkOperatorX<LocalStateType>::create_shar
return nullptr;
} else if constexpr (std::is_same_v<typename
LocalStateType::SharedStateType,
MultiCastSharedState>) {
- LOG(FATAL) << "should not reach here!";
- return nullptr;
+ throw Exception(Status::FatalError("should not reach here!"));
Review Comment:
try use `static_assert` for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
