eldenmoon commented on code in PR #42269:
URL: https://github.com/apache/doris/pull/42269#discussion_r1857996603
##########
be/src/vec/columns/column.h:
##########
@@ -481,11 +481,12 @@ class IColumn : public COW<IColumn> {
virtual Ptr replicate(const Offsets& offsets) const = 0;
/// Appends one field multiple times. Can be optimized in inherited
classes.
- virtual void insert_many(const Field& field, size_t length) {
- for (size_t i = 0; i < length; ++i) {
- insert(field);
- }
- }
+ // this function has not used ??
Review Comment:
if not used remove
##########
be/test/vec/columns/column_ip_test.cpp:
##########
@@ -0,0 +1,330 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
Review Comment:
column_ip_test.cpp lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
