github-actions[bot] commented on code in PR #44331:
URL: https://github.com/apache/doris/pull/44331#discussion_r1849689014
##########
be/src/runtime/workload_group/workload_group_manager.cpp:
##########
@@ -613,15 +622,16 @@ int64_t
WorkloadGroupMgr::cancel_top_query_in_overcommit_group_(int64_t need_fre
// If the query could release some memory, for example, spill disk, then the
return value is true.
// If the query could not release memory, then cancel the query, the return
value is true.
// If the query is not ready to do these tasks, it means just wait, then
return value is false.
-bool WorkloadGroupMgr::handle_single_query_(std::shared_ptr<QueryContext>
query_ctx,
- size_t size_to_reserve, Status
paused_reason) {
+bool WorkloadGroupMgr::handle_single_query_(const
std::shared_ptr<QueryContext>& query_ctx,
Review Comment:
warning: function 'handle_single_query_' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
bool WorkloadGroupMgr::handle_single_query_(const
std::shared_ptr<QueryContext>& query_ctx,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/workload_group/workload_group_manager.cpp:624:** 97 lines
including whitespace and comments (threshold 80)
```cpp
bool WorkloadGroupMgr::handle_single_query_(const
std::shared_ptr<QueryContext>& query_ctx,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
