csun5285 commented on code in PR #44120:
URL: https://github.com/apache/doris/pull/44120#discussion_r1847857549


##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1642,6 +1642,8 @@ void 
MetaServiceImpl::get_tablet_stats(::google::protobuf::RpcController* contro
 #ifdef NDEBUG
         // Force data size >= 0 to reduce the losses caused by bugs
         if (tablet_stats->data_size() < 0) tablet_stats->set_data_size(0);
+        if (tablet_stats->index_size() < 0) tablet_stats->set_index_size(0);

Review Comment:
   The data currently only shows the data size. 



##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1642,6 +1642,8 @@ void 
MetaServiceImpl::get_tablet_stats(::google::protobuf::RpcController* contro
 #ifdef NDEBUG
         // Force data size >= 0 to reduce the losses caused by bugs
         if (tablet_stats->data_size() < 0) tablet_stats->set_data_size(0);
+        if (tablet_stats->index_size() < 0) tablet_stats->set_index_size(0);

Review Comment:
   By adding the index size and segment size, it becomes clear that the index 
size + segment size = data size. Without the index size, it's difficult to 
explain this clearly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to