HappenLee commented on code in PR #44169:
URL: https://github.com/apache/doris/pull/44169#discussion_r1847551010
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1355,20 +1355,18 @@ Status IRuntimeFilter::init_with_desc(const
TRuntimeFilterDesc* desc, const TQue
params.runtime_bloom_filter_max_size =
options->__isset.runtime_bloom_filter_max_size
?
options->runtime_bloom_filter_max_size
: 0;
- // We build runtime filter by exact distinct count iff three conditions
are met:
+ auto sync_filter_size = desc->__isset.sync_filter_size &&
desc->sync_filter_size;
+ // We build runtime filter by exact distinct count if all of 3 conditions
are met:
Review Comment:
should add broadcast join
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
