HappenLee commented on code in PR #43777:
URL: https://github.com/apache/doris/pull/43777#discussion_r1839640159
##########
be/src/vec/aggregate_functions/aggregate_function_stddev.h:
##########
@@ -191,14 +165,25 @@ struct SampData : Data {
static DataTypePtr get_return_type() { return
std::make_shared<DataTypeNumber<Float64>>(); }
};
-template <bool is_pop, typename Data, bool is_nullable>
+struct StddevName {
+ static const char* name() { return "stddev"; }
+};
+struct VarianceName {
+ static const char* name() { return "variance"; }
+};
+struct VarianceSampName {
+ static const char* name() { return "variance_samp"; }
+};
+struct StddevSampName {
+ static const char* name() { return "stddev_samp"; }
+};
+
+template <bool is_pop, typename Data>
Review Comment:
so what is_pop use? seems unless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
