github-actions[bot] commented on code in PR #43802:
URL: https://github.com/apache/doris/pull/43802#discussion_r1839488090
##########
cloud/test/meta_service_http_test.cpp:
##########
@@ -1456,4 +1456,83 @@ TEST(MetaServiceHttpTest, TxnLazyCommit) {
}
}
+TEST(MetaServiceHttpTest, get_stage_response_sk) {
+ auto sp = SyncPoint::get_instance();
+ sp->enable_processing();
+ std::unique_ptr<int, std::function<void(int*)>> defer((int*)0x01,
+ [&](...) {
sp->disable_processing(); });
+
+ GetStageResponse res;
Review Comment:
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
```suggestion
e_sk) {auto *
```
##########
cloud/src/meta-service/meta_service_helper.h:
##########
@@ -19,7 +19,9 @@
#include <brpc/controller.h>
Review Comment:
warning: 'brpc/controller.h' file not found [clang-diagnostic-error]
```cpp
#include <brpc/controller.h>
^
```
##########
cloud/test/meta_service_http_test.cpp:
##########
@@ -1456,4 +1456,83 @@
}
}
+TEST(MetaServiceHttpTest, get_stage_response_sk) {
+ auto sp = SyncPoint::get_instance();
+ sp->enable_processing();
+ std::unique_ptr<int, std::function<void(int*)>> defer((int*)0x01,
+ [&](...) {
sp->disable_processing(); });
+
+ GetStageResponse res;
+ auto* stage = res.add_stage();
+ stage->mutable_obj_info()->set_ak("stage-ak");
+ stage->mutable_obj_info()->set_sk("stage-sk");
+ auto foo = [res](auto args) {
(*(try_any_cast<GetStageResponse**>(args[0])))->CopyFrom(res); };
+ sp->set_call_back("stage_sk_response", foo);
+ sp->set_call_back("stage_sk_response_return",
+ [](auto&& args) { *try_any_cast<bool*>(args.back()) =
true; });
+
+ auto rate_limiter = std::make_shared<cloud::RateLimiter>();
+
+ auto ms = std::make_unique<cloud::MetaServiceImpl>(nullptr, nullptr,
rate_limiter);
+
+ auto bar = [](auto args) {
+ std::cout << *try_any_cast<std::string*>(args[0]);
+
+ EXPECT_TRUE((*try_any_cast<std::string*>(args[0])).find("stage-sk") ==
std::string::npos);
+ EXPECT_TRUE((*try_any_cast<std::string*>(args[0]))
+ .find("md5: f497d053066fa4b7d3b1f6564597d233") !=
std::string::npos);
+ };
+ sp->set_call_back("sk_finish_rpc", bar);
+
+ GetStageResponse res1;
+ GetStageRequest req1;
+ brpc::Controller cntl;
+ ms->get_stage(&cntl, &req1, &res1, nullptr);
+}
+
+TEST(MetaServiceHttpTest, get_obj_store_info_response_sk) {
+ auto sp = SyncPoint::get_instance();
+ sp->enable_processing();
+ std::unique_ptr<int, std::function<void(int*)>> defer((int*)0x01,
+ [&](...) {
sp->disable_processing(); });
+
+ GetObjStoreInfoResponse res;
Review Comment:
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
```suggestion
e_sk) {auto *
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
