github-actions[bot] commented on code in PR #43574:
URL: https://github.com/apache/doris/pull/43574#discussion_r1839284279
##########
be/src/olap/rowset/vertical_beta_rowset_writer.cpp:
##########
@@ -50,7 +50,8 @@ template <class T>
requires std::is_base_of_v<BaseBetaRowsetWriter, T>
Status VerticalBetaRowsetWriter<T>::add_columns(const vectorized::Block* block,
Review Comment:
warning: function 'add_columns' has cognitive complexity of 73 (threshold
50) [readability-function-cognitive-complexity]
```cpp
Status VerticalBetaRowsetWriter<T>::add_columns(const vectorized::Block*
block,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:58:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (num_rows == 0) {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:61:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (UNLIKELY(max_rows_per_segment > context.max_rows_per_segment)) {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:65:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (_segment_writers.empty()) {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:69:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_create_segment_writer(col_ids, is_key, &writer));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:69:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_create_segment_writer(col_ids, is_key, &writer));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:72:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->append_block(block, 0,
num_rows));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:72:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->append_block(block, 0,
num_rows));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:73:** +1, nesting level
increased to 1
```cpp
} else if (is_key) {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:76:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (_segment_writers[_cur_writer_idx]->num_rows_written() >
max_rows_per_segment ||
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:79:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_flush_columns(_segment_writers[_cur_writer_idx].get(), true));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:79:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_flush_columns(_segment_writers[_cur_writer_idx].get(), true));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:82:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_create_segment_writer(col_ids, is_key,
&writer));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:82:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_create_segment_writer(col_ids, is_key,
&writer));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:86:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->append_block(block, 0,
num_rows));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:86:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->append_block(block, 0,
num_rows));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:87:** +1, nesting level
increased to 1
```cpp
} else {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:90:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
while (left > 0) {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:97:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (num_rows_written == 0) {
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:99:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->init(col_ids, is_key));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:99:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->init(col_ids, is_key));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:103:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
? num_rows_key_group -
num_rows_written
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:105:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->append_block(block, num_rows
- left,
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:105:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->append_block(block, num_rows
- left,
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:110:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (num_rows_key_group == num_rows_written + to_write &&
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:112:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_flush_columns(_segment_writers[_cur_writer_idx].get()));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:112:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(_flush_columns(_segment_writers[_cur_writer_idx].get()));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/vertical_beta_rowset_writer.cpp:117:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (is_key) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
