github-actions[bot] commented on code in PR #41362:
URL: https://github.com/apache/doris/pull/41362#discussion_r1838178552


##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1418,6 +1418,108 @@ static bool try_fetch_and_parse_schema(Transaction* 
txn, RowsetMetaCloudPB& rows
     return true;
 }
 
+void MetaServiceImpl::get_tmp_rowset(::google::protobuf::RpcController* 
controller,

Review Comment:
   warning: function 'get_tmp_rowset' exceeds recommended size/complexity 
thresholds [readability-function-size]
   ```cpp
   void MetaServiceImpl::get_tmp_rowset(::google::protobuf::RpcController* 
controller,
                         ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **cloud/src/meta-service/meta_service.cpp:1420:** 97 lines including 
whitespace and comments (threshold 80)
   ```cpp
   void MetaServiceImpl::get_tmp_rowset(::google::protobuf::RpcController* 
controller,
                         ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to