This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 3ba7cc52e22 [opt](binlog) Support modify comment binlog #39783 (#43762)
3ba7cc52e22 is described below
commit 3ba7cc52e22c1448c5f83ce4183fb3f2ab7ed00e
Author: walter <w41te...@gmail.com>
AuthorDate: Tue Nov 12 21:31:21 2024 +0800
[opt](binlog) Support modify comment binlog #39783 (#43762)
cherry pick from #39783
Co-authored-by: smallx <e99...@163.com>
---
.../src/main/java/org/apache/doris/binlog/BinlogManager.java | 12 ++++++++++++
.../src/main/java/org/apache/doris/persist/EditLog.java | 4 +++-
.../org/apache/doris/persist/ModifyCommentOperationLog.java | 4 ++++
gensrc/thrift/FrontendService.thrift | 1 +
4 files changed, 20 insertions(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/binlog/BinlogManager.java
b/fe/fe-core/src/main/java/org/apache/doris/binlog/BinlogManager.java
index 079a3c6527a..60d091bf202 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/binlog/BinlogManager.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/binlog/BinlogManager.java
@@ -29,6 +29,7 @@ import org.apache.doris.persist.BarrierLog;
import org.apache.doris.persist.BatchModifyPartitionsInfo;
import org.apache.doris.persist.BinlogGcInfo;
import org.apache.doris.persist.DropPartitionInfo;
+import org.apache.doris.persist.ModifyCommentOperationLog;
import org.apache.doris.persist.ModifyTablePropertyOperationLog;
import org.apache.doris.persist.ReplacePartitionOperationLog;
import org.apache.doris.persist.TableAddOrDropColumnsInfo;
@@ -331,6 +332,17 @@ public class BinlogManager {
addBinlog(dbId, tableIds, commitSeq, timestamp, type, data, false,
info);
}
+ public void addModifyComment(ModifyCommentOperationLog info, long
commitSeq) {
+ long dbId = info.getDbId();
+ List<Long> tableIds = Lists.newArrayList();
+ tableIds.add(info.getTblId());
+ long timestamp = -1;
+ TBinlogType type = TBinlogType.MODIFY_COMMENT;
+ String data = info.toJson();
+
+ addBinlog(dbId, tableIds, commitSeq, timestamp, type, data, false,
info);
+ }
+
public void addColumnRename(TableRenameColumnInfo info, long commitSeq) {
long dbId = info.getDbId();
List<Long> tableIds = Lists.newArrayList();
diff --git a/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
b/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
index bb47a54d202..9b271344a0a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java
@@ -1956,7 +1956,9 @@ public class EditLog {
}
public void logModifyComment(ModifyCommentOperationLog op) {
- logEdit(OperationType.OP_MODIFY_COMMENT, op);
+ long logId = logEdit(OperationType.OP_MODIFY_COMMENT, op);
+ LOG.info("log modify comment, logId : {}, infos: {}", logId, op);
+ Env.getCurrentEnv().getBinlogManager().addModifyComment(op, logId);
}
public void logCreateSqlBlockRule(SqlBlockRule rule) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/persist/ModifyCommentOperationLog.java
b/fe/fe-core/src/main/java/org/apache/doris/persist/ModifyCommentOperationLog.java
index 0b6f1f98450..f9bb7f5084e 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/persist/ModifyCommentOperationLog.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/persist/ModifyCommentOperationLog.java
@@ -94,4 +94,8 @@ public class ModifyCommentOperationLog implements Writable {
String json = Text.readString(in);
return GsonUtils.GSON.fromJson(json, ModifyCommentOperationLog.class);
}
+
+ public String toJson() {
+ return GsonUtils.GSON.toJson(this);
+ }
}
diff --git a/gensrc/thrift/FrontendService.thrift
b/gensrc/thrift/FrontendService.thrift
index 7078d5eaeab..9b34e86c28a 100644
--- a/gensrc/thrift/FrontendService.thrift
+++ b/gensrc/thrift/FrontendService.thrift
@@ -1187,6 +1187,7 @@ enum TBinlogType {
TRUNCATE_TABLE = 13,
RENAME_TABLE = 14,
RENAME_COLUMN = 15,
+ MODIFY_COMMENT = 16,
}
struct TBinlog {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
