yiguolei commented on code in PR #43624:
URL: https://github.com/apache/doris/pull/43624#discussion_r1837879912
##########
be/src/vec/columns/column_string.cpp:
##########
@@ -134,34 +133,41 @@ void ColumnStr<T>::insert_range_from(const IColumn& src,
size_t start, size_t le
if (length == 0) {
return;
}
+ auto do_insert = [&](const auto& src_concrete) {
+ const auto& src_offsets = src_concrete.get_offsets();
+ const auto& src_chars = src_concrete.get_chars();
Review Comment:
add comment to insert_range_from_ignore_overflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
