This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch test_email
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/test_email by this push:
new 4079715fa92 f (#43663)
4079715fa92 is described below
commit 4079715fa92bbc080d8ce86db2dbce9734ee1a0c
Author: yiguolei <guo...@selectdb.com>
AuthorDate: Tue Nov 12 12:05:24 2024 +0800
f (#43663)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/olap/base_compaction.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/olap/base_compaction.cpp b/be/src/olap/base_compaction.cpp
index 298881788d5..8b9cbd75ed3 100644
--- a/be/src/olap/base_compaction.cpp
+++ b/be/src/olap/base_compaction.cpp
@@ -120,7 +120,7 @@ Status BaseCompaction::pick_rowsets_to_compact() {
// If there are delete predicate rowsets in tablet, start_version > 0
implies some rowsets before
// delete version cannot apply these delete predicates, which can cause
incorrect query result.
// So we must abort this base compaction.
- // Typical scenario is that some rowsets before cumulative point are on
remote storage.
+ // A typical scenario is that some rowsets before cumulative point are on
remote storage.
// For example, consider rowset[0,3] is on remote storage, now we pass
[4,4],[5,5],[6,9]
// to do base compaction and rowset[5,5] is delete predicate rowset, if we
allow them to do
// such procedure, then we'll get [4,9] while it will lose the delete
predicate information in [5,5]
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
