github-actions[bot] commented on code in PR #43542:
URL: https://github.com/apache/doris/pull/43542#discussion_r1835692708
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -240,15 +240,17 @@ Status InvertedIndexReader::match_index_search(
return Status::OK();
}
-Status FullTextIndexReader::new_iterator(OlapReaderStatistics* stats,
RuntimeState* runtime_state,
+Status FullTextIndexReader::new_iterator(const io::IOContext* io_ctx,
OlapReaderStatistics* stats,
+ RuntimeState* runtime_state,
std::unique_ptr<InvertedIndexIterator>* iterator) {
- *iterator = InvertedIndexIterator::create_unique(stats, runtime_state,
shared_from_this());
+ *iterator =
+ InvertedIndexIterator::create_unique(io_ctx, stats, runtime_state,
shared_from_this());
return Status::OK();
}
-Status FullTextIndexReader::query(OlapReaderStatistics* stats, RuntimeState*
runtime_state,
- const std::string& column_name, const void*
query_value,
- InvertedIndexQueryType query_type,
+Status FullTextIndexReader::query(const io::IOContext* io_ctx,
OlapReaderStatistics* stats,
Review Comment:
warning: function 'query' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status FullTextIndexReader::query(const io::IOContext* io_ctx,
OlapReaderStatistics* stats,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:250:** 81 lines
including whitespace and comments (threshold 80)
```cpp
Status FullTextIndexReader::query(const io::IOContext* io_ctx,
OlapReaderStatistics* stats,
^
```
</details>
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -337,13 +339,15 @@
}
Status StringTypeInvertedIndexReader::new_iterator(
- OlapReaderStatistics* stats, RuntimeState* runtime_state,
+ const io::IOContext* io_ctx, OlapReaderStatistics* stats,
RuntimeState* runtime_state,
std::unique_ptr<InvertedIndexIterator>* iterator) {
- *iterator = InvertedIndexIterator::create_unique(stats, runtime_state,
shared_from_this());
+ *iterator =
+ InvertedIndexIterator::create_unique(io_ctx, stats, runtime_state,
shared_from_this());
return Status::OK();
}
-Status StringTypeInvertedIndexReader::query(OlapReaderStatistics* stats,
+Status StringTypeInvertedIndexReader::query(const io::IOContext* io_ctx,
Review Comment:
warning: function 'query' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status StringTypeInvertedIndexReader::query(const io::IOContext* io_ctx,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:348:** 117 lines
including whitespace and comments (threshold 80)
```cpp
Status StringTypeInvertedIndexReader::query(const io::IOContext* io_ctx,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
