gavinchou commented on code in PR #43440:
URL: https://github.com/apache/doris/pull/43440#discussion_r1832457262
##########
be/src/io/cache/fs_file_cache_storage.h:
##########
@@ -102,6 +102,12 @@ class FSFileCacheStorage : public FileCacheStorage {
void load_cache_info_into_memory(BlockFileCache* _mgr) const;
+ void check_consistency(
+ BlockFileCache* _mgr,
Review Comment:
Better not couple this interface with FileCacheManager. The method of
checking here is that the storage can return a list with comprehensive "file"
information (including path, size, creation time, etc.), preferably in an
ordered manner. Let the FileCacheManager, which depends on this storage,
perform its own forward and reverse checks to see if there is any extra or
missing data in the storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
