github-actions[bot] commented on code in PR #43386:
URL: https://github.com/apache/doris/pull/43386#discussion_r1831461779
##########
be/src/util/arrow/row_batch.cpp:
##########
@@ -46,7 +46,8 @@ namespace doris {
using strings::Substitute;
-Status convert_to_arrow_type(const TypeDescriptor& type,
std::shared_ptr<arrow::DataType>* result) {
+Status convert_to_arrow_type(const TypeDescriptor& type,
std::shared_ptr<arrow::DataType>* result,
Review Comment:
warning: function 'convert_to_arrow_type' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status convert_to_arrow_type(const TypeDescriptor& type,
std::shared_ptr<arrow::DataType>* result,
^
```
<details>
<summary>Additional context</summary>
**be/src/util/arrow/row_batch.cpp:48:** 108 lines including whitespace and
comments (threshold 80)
```cpp
Status convert_to_arrow_type(const TypeDescriptor& type,
std::shared_ptr<arrow::DataType>* result,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
