HappenLee commented on code in PR #43228:
URL: https://github.com/apache/doris/pull/43228#discussion_r1828737576
##########
be/src/vec/columns/column_complex.h:
##########
@@ -205,10 +208,15 @@ class ColumnComplexType final : public COWHelper<IColumn,
ColumnComplexType<T>>
// it's impossible to use ComplexType as key , so we don't have to
implement them
[[noreturn]] StringRef serialize_value_into_arena(size_t n, Arena& arena,
char const*& begin)
const override {
- LOG(FATAL) << "serialize_value_into_arena not implemented";
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR,
+ "serialize_value_into_arena not implemented");
+ __builtin_unreachable();
}
[[noreturn]] const char* deserialize_and_insert_from_arena(const char*
pos) override {
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR,
+ "deserialize_and_insert_from_arena not
implemented");
+ __builtin_unreachable();
LOG(FATAL) << "deserialize_and_insert_from_arena not implemented";
Review Comment:
should we delete the `log(fatal)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
