gavinchou commented on code in PR #42680:
URL: https://github.com/apache/doris/pull/42680#discussion_r1826606429
##########
be/src/cloud/pb_convert.cpp:
##########
@@ -287,6 +287,7 @@ void doris_tablet_schema_to_cloud(TabletSchemaCloudPB* out,
const TabletSchemaPB
out->set_inverted_index_storage_format(in.inverted_index_storage_format());
out->set_enable_variant_flatten_nested(in.variant_enable_flatten_nested());
out->set_skip_bitmap_col_idx(in.skip_bitmap_col_idx());
+ out->set_storage_page_size(in.storage_page_size());
Review Comment:
I suggest this property storing in TabletMetaPB.
do not follow the existing `row_storage_page` thing, it was not correctly
placed, it is not a schema thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
