eldenmoon commented on code in PR #41482:
URL: https://github.com/apache/doris/pull/41482#discussion_r1823737327


##########
cloud/src/meta-service/meta_service_schema.cpp:
##########
@@ -331,6 +340,12 @@ void read_schema_from_dict(MetaServiceCode& code, 
std::string& msg, const std::s
     LOG(INFO) << "Get schema_dict, column size=" << dict.column_dict_size()
               << ", index size=" << dict.index_dict_size();
 
+    // Return dict, let backend to fill schema with dict info
+    if (schema_op == GetRowsetRequest::RETURN_DICT) {
+        response->mutable_schema_dict()->Swap(&dict);

Review Comment:
   for most of cases the large  ratio of dict is usefull , so the optimization 
is worthy of
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to