mymeiyi commented on code in PR #41759:
URL: https://github.com/apache/doris/pull/41759#discussion_r1823710141
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java:
##########
@@ -858,6 +866,33 @@ private void getDeleteBitmapUpdateLock(Map<Long,
Set<Long>> tableToParttions, lo
}
}
+ private void removeDeleteBitmapUpdateLock(Map<Long, Set<Long>>
tableToParttions, long transactionId) {
+ for (Map.Entry<Long, Set<Long>> entry : tableToParttions.entrySet()) {
+ RemoveDeleteBitmapUpdateLockRequest.Builder builder =
RemoveDeleteBitmapUpdateLockRequest.newBuilder();
+ builder.setTableId(entry.getKey())
+ .setLockId(transactionId)
+ .setInitiator(-1);
+ final RemoveDeleteBitmapUpdateLockRequest request =
builder.build();
+ RemoveDeleteBitmapUpdateLockResponse response = null;
+ try {
+ response =
MetaServiceProxy.getInstance().removeDeleteBitmapUpdateLock(request);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("remove delete bitmap lock, transactionId={},
Request: {}, Response: {}",
+ transactionId, request, response);
+ }
+ } catch (Exception e) {
+ LOG.warn("ignore get delete bitmap lock exception,
transactionId={}, exception={}",
+ transactionId, e);
+ }
+ Preconditions.checkNotNull(response);
Review Comment:
response is null if exception is thrown in line 883, the check must fail, so
line 884 ignore the exception does not work? if you want to ignore the
exception, maybe you should move these operations into the `try` logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
