This is an automated email from the ASF dual-hosted git repository.
liaoxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a33fb09f270 [test](p0) fix load stream leak in injection cases (#42681)
a33fb09f270 is described below
commit a33fb09f27005cd316e7d9cc66335c6a7e6e2939
Author: Kaijie Chen <c...@apache.org>
AuthorDate: Thu Oct 31 00:00:21 2024 +0800
[test](p0) fix load stream leak in injection cases (#42681)
## Proposed changes
Some injection cases (e.g.
`VTabletWriterV2._open_streams_to_backend.node_info_null`) will cause
LoadStream leak.
Because the injection was disabled too early.
When some sink operators returns "failed" status to the user (regression
framework), other sinks are still executing.
Causing partially opened LoadStreams (some instances are not
fault-injected, and successfully open the stream).
We should wait a small amount of time to safely assume all instances are
done, before disabling the injection.
---
.../suites/fault_injection_p0/test_writer_v2_fault_injection.groovy | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
b/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
index 373ceef469e..f05a084035c 100644
---
a/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
+++
b/regression-test/suites/fault_injection_p0/test_writer_v2_fault_injection.groovy
@@ -73,8 +73,10 @@ suite("test_writer_v2_fault_injection", "nonConcurrent") {
sql "insert into test select * from baseall where k1 <= 3"
} catch(Exception e) {
logger.info(e.getMessage())
- assertTrue(e.getMessage().contains(error_msg))
+ assertTrue(e.getMessage().contains(error_msg),
+ String.format("expected '%s', actual '%s'", error_msg,
e.getMessage()))
} finally {
+ sleep 1000 // wait some time for instance finish before disable
injection
GetDebugPoint().disableDebugPointForAllBEs(injection)
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
