github-actions[bot] commented on code in PR #42898:
URL: https://github.com/apache/doris/pull/42898#discussion_r1822022027
##########
be/src/pipeline/exec/streaming_aggregation_operator.cpp:
##########
@@ -848,12 +841,12 @@ Status
StreamingAggLocalState::_get_with_serialized_key_result(RuntimeState* sta
return Status::OK();
}
-Status StreamingAggLocalState::_serialize_without_key(RuntimeState* state,
vectorized::Block* block,
- bool* eos) {
+Status StreamingAggLocalState::_get_results_without_key(RuntimeState* state,
Review Comment:
warning: method '_get_results_without_key' can be made const
[readability-make-member-function-const]
be/src/pipeline/exec/streaming_aggregation_operator.cpp:844:
```diff
- vectorized::Block*
block, bool* eos) {
+ vectorized::Block*
block, bool* eos) const {
```
be/src/pipeline/exec/streaming_aggregation_operator.h:67:
```diff
- Status _get_results_without_key(RuntimeState* state,
vectorized::Block* block, bool* eos);
+ Status _get_results_without_key(RuntimeState* state,
vectorized::Block* block, bool* eos) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
