morrySnow commented on code in PR #41730:
URL: https://github.com/apache/doris/pull/41730#discussion_r1816056879
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -289,4 +394,55 @@ private boolean childIsEmptyRelation(PhysicalSink sink) {
public StmtType stmtType() {
return StmtType.INSERT;
}
+
+ private static class ExecutorFactory {
Review Comment:
add comment to explain what this class does
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/distribute/worker/ScanWorkerSelector.java:
##########
@@ -49,14 +51,14 @@ public interface ScanWorkerSelector {
// and distributed by hash(id) buckets 10. And, so,
there has 10 buckets from bucket 0 to
// bucket 9, and every bucket contains two tablets,
because there are two partitions.
Map<DistributedPlanWorker, UninstancedScanSource>
selectReplicaAndWorkerWithBucket(
- UnassignedScanBucketOlapTableJob unassignedJob);
+ UnassignedScanBucketOlapTableJob unassignedJob, ConnectContext
context);
static TScanRangeParams buildScanReplicaParams(
TScanRangeLocations tabletLocation, TScanRangeLocation
replicaLocation) {
TScanRangeParams replicaParam = new TScanRangeParams();
replicaParam.scan_range = tabletLocation.scan_range;
// Volume is optional, so we need to set the value and the is-set bit
- replicaParam.setVolumeId(replicaLocation.volume_id);
+ // replicaParam.setVolumeId(replicaLocation.volume_id);
Review Comment:
remove useless code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
