yiguolei commented on code in PR #42371:
URL: https://github.com/apache/doris/pull/42371#discussion_r1814220694
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -480,17 +480,14 @@ bool
ExchangeSinkBuffer<Parent>::_is_receiver_eof(InstanceLoId id) {
}
template <typename Parent>
-void ExchangeSinkBuffer<Parent>::_turn_off_channel(InstanceLoId id, bool
cleanup) {
+void ExchangeSinkBuffer<Parent>::_turn_off_channel(InstanceLoId id) {
if (!_rpc_channel_is_idle[id]) {
_rpc_channel_is_idle[id] = true;
- auto all_done = _busy_channels.fetch_sub(1) == 1;
- _set_ready_to_finish(all_done);
- if (cleanup && all_done) {
- auto weak_task_ctx = weak_task_exec_ctx();
- if (auto pip_ctx = weak_task_ctx.lock()) {
- DCHECK(_parent);
- _parent->set_reach_limit();
- }
+ _busy_channels.fetch_sub(1) == 1;
+ auto weak_task_ctx = weak_task_exec_ctx();
+ if (auto pip_ctx = weak_task_ctx.lock()) {
+ DCHECK(_parent);
+ _parent->on_channel_finished(id);
Review Comment:
可能得把代码移动到parent 里
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
