This is an automated email from the ASF dual-hosted git repository.

airborne pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new b4473edc8ce [test](inverted index) enhace test_build_index case for 
quickly finished jobs (#42150)
b4473edc8ce is described below

commit b4473edc8cec0e1b172b4f6fc4fdca80dbc50c41
Author: airborne12 <[email protected]>
AuthorDate: Mon Oct 21 15:45:28 2024 +0800

    [test](inverted index) enhace test_build_index case for quickly finished 
jobs (#42150)
    
    ## Proposed changes
    
    Fix case failure like below
    ```
    Exception in inverted_index_p0/test_build_index.groovy(line 185):
    
        wait_for_latest_op_on_table_finish(tableName, timeout)
    
        // BUILD INDEX and expect state is RUNNING
        sql """ BUILD INDEX idx_comment ON ${tableName} """
        def state = wait_for_last_build_index_on_table_running(tableName, 
timeout)
        if (state != "SKIPPED") {
            def result = sql """ SHOW BUILD INDEX WHERE TableName = 
"${tableName}" ORDER BY JobId """
            assertEquals(result[result.size()-1][1], tableName)
            assertTrue(result[result.size()-1][3].contains("ADD INDEX"))
            assertEquals(result[result.size()-1][7], "RUNNING")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^^
    
            // CANCEL BUILD INDEX and expect state is CANCELED
            sql """ CANCEL BUILD INDEX ON ${tableName} 
(${result[result.size()-1][0]}) """
            result = sql """ SHOW BUILD INDEX WHERE TableName = "${tableName}" 
ORDER BY JobId """
            assertEquals(result[result.size()-1][1], tableName)
            assertTrue(result[result.size()-1][3].contains("ADD INDEX"))
            assertEquals(result[result.size()-1][7], "CANCELLED")
            assertEquals(result[result.size()-1][8], "user cancelled")
    
            // BUILD INDEX and expect state is FINISHED
    
    Exception:
    org.opentest4j.AssertionFailedError: expected: <FINISHED> but was: <RUNNING>
    ```
---
 .../suites/inverted_index_p0/index_change/test_build_index.groovy     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/regression-test/suites/inverted_index_p0/index_change/test_build_index.groovy 
b/regression-test/suites/inverted_index_p0/index_change/test_build_index.groovy
index 3b15c07260e..66829f03370 100644
--- 
a/regression-test/suites/inverted_index_p0/index_change/test_build_index.groovy
+++ 
b/regression-test/suites/inverted_index_p0/index_change/test_build_index.groovy
@@ -97,7 +97,7 @@ suite("test_build_index", "inverted_index"){
             }
             if (alter_res.size() > 0) {
                 def last_job_state = alter_res[alter_res.size()-1][7];
-                if (last_job_state == "RUNNING") {
+                if (last_job_state == "RUNNING" || last_job_state == 
"FINISHED") {
                     logger.info(table_name + " last index job running, state: 
" + last_job_state + ", detail: " + alter_res)
                     return last_job_state;
                 }
@@ -181,7 +181,7 @@ suite("test_build_index", "inverted_index"){
     // BUILD INDEX and expect state is RUNNING
     sql """ BUILD INDEX idx_comment ON ${tableName} """
     def state = wait_for_last_build_index_on_table_running(tableName, timeout)
-    if (state != "SKIPPED") {
+    if (state == "RUNNING") {
         def result = sql """ SHOW BUILD INDEX WHERE TableName = "${tableName}" 
ORDER BY JobId """
         assertEquals(result[result.size()-1][1], tableName)
         assertTrue(result[result.size()-1][3].contains("ADD INDEX"))


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to