zhiqiang-hhhh commented on code in PR #39187:
URL: https://github.com/apache/doris/pull/39187#discussion_r1797619433
##########
be/src/vec/aggregate_functions/aggregate_function_regr_union.h:
##########
@@ -45,12 +45,14 @@ struct AggregateFunctionRegrData {
Float64 sum_y {};
Float64 sum_of_x_mul_y {};
Float64 sum_of_x_squared {};
+ Float64 sum_of_y_squared {};
Review Comment:
`sum_of_y_squared` is only needed for `regr_syy`, in other situations, this
field is not necessary.
so we should use template to make our implementation more efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
