HappenLee commented on code in PR #9167:
URL: https://github.com/apache/incubator-doris/pull/9167#discussion_r857065157
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -297,6 +307,23 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
return -1;
}
+ inline StringValue& get_value(T code) { return _dict_data[code]; }
+
+ inline void generate_hash_values() {
+ if (_hash_values.size() == 0) {
+ _hash_values.reserve(_dict_data.size());
Review Comment:
1. less code
2. more quickly. each time you push back need to do `_size ++`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
