xinyiZzz commented on code in PR #41310:
URL: https://github.com/apache/doris/pull/41310#discussion_r1795478263
##########
be/src/runtime/memory/global_memory_arbitrator.h:
##########
@@ -192,7 +200,7 @@ class GlobalMemoryArbitrator {
}
private:
- static std::atomic<int64_t> _s_process_reserved_memory;
Review Comment:
这个类里面其他 static 都没有 s，这是当初笔误了
只有 MemInfo 里的 static 加了 s，为了和历史保持一致，其他地方都不要s了吧
##########
be/src/runtime/memory/memory_profile.h:
##########
@@ -0,0 +1,75 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "util/runtime_profile.h"
+
+namespace doris {
+
+class MemoryProfile {
Review Comment:
done
##########
be/src/common/config.cpp:
##########
@@ -150,8 +150,10 @@ DEFINE_mInt64(stacktrace_in_alloc_large_memory_bytes,
"2147483648");
DEFINE_mInt64(crash_in_alloc_large_memory_bytes, "-1");
-// If memory tracker value is inaccurate, BE will crash. usually used in test
environments, default value is false.
-DEFINE_mBool(crash_in_memory_tracker_inaccurate, "false");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
