xiaokang commented on code in PR #41608: URL: https://github.com/apache/doris/pull/41608#discussion_r1794842733
########## be/src/olap/segment_loader.cpp: ########## @@ -59,8 +59,14 @@ Status SegmentLoader::load_segments(const BetaRowsetSharedPtr& rowset, for (int64_t i = 0; i < rowset->num_segments(); i++) { SegmentCache::CacheKey cache_key(rowset->rowset_id(), i); if (_segment_cache->lookup(cache_key, cache_handle)) { - continue; + // Has to check the segment status here, because the segment in cache may has something wrong during Review Comment: Why not check status in lookup and erase not healthy segment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org