gavinchou commented on code in PR #41608:
URL: https://github.com/apache/doris/pull/41608#discussion_r1793865357
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -554,11 +554,17 @@ vectorized::DataTypePtr Segment::get_data_type_of(const
ColumnIdentifier& identi
}
Status Segment::_create_column_readers_once() {
- return _create_column_readers_once_call.call([&] {
- DCHECK(_footer_pb);
- Defer defer([&]() { _footer_pb.reset(); });
- return _create_column_readers(*_footer_pb);
- });
+ auto status = [this]() {
Review Comment:
why not just
```
auto status = _create_column_readers_once_call.call(...);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
