xzj7019 commented on code in PR #40878: URL: https://github.com/apache/doris/pull/40878#discussion_r1777970156
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ReplacePredicate.java: ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.common.Pair; +import org.apache.doris.nereids.CascadesContext; +import org.apache.doris.nereids.analyzer.Scope; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.rules.analysis.ExpressionAnalyzer; +import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext; +import org.apache.doris.nereids.trees.expressions.Cast; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.InPredicate; +import org.apache.doris.nereids.trees.expressions.Like; +import org.apache.doris.nereids.trees.expressions.Not; +import org.apache.doris.nereids.trees.expressions.Or; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.functions.ExpressionTrait; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.types.DecimalV2Type; +import org.apache.doris.nereids.types.DecimalV3Type; +import org.apache.doris.nereids.util.ImmutableEqualSet; +import org.apache.doris.nereids.util.PredicateInferUtils; +import org.apache.doris.nereids.util.TypeCoercionUtils; + +import com.google.common.collect.ImmutableList; +import org.jetbrains.annotations.Nullable; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +/**ReplacePredicate*/ +public class ReplacePredicate { + private static List<Expression> getAllSubExpressions(Expression expr) { + List<Expression> subExpressions = new ArrayList<>(); + getAllSubExpressions(expr, subExpressions); + return subExpressions; + } + + private static void getAllSubExpressions(Expression expr, List<Expression> res) { + res.add(expr); + if (expr.children().size() != 1) { + Set<Slot> slots = expr.getInputSlots(); + if (slots.size() == 1) { + res.add(slots.iterator().next()); + } + return; + } + getAllSubExpressions(expr.child(0), res); + } + + /** fill map exprPredicates : expression and all its corresponding predicates */ + private static class PredicatesCollector extends ExpressionVisitor<Void, Map<Expression, Set<Expression>>> { + public static PredicatesCollector INSTANCE = new PredicatesCollector(); + + @Override + public Void visit(Expression expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitOr(Or expr, Map<Expression, Set<Expression>> context) { + return null; + } + + @Override + public Void visitInPredicate(InPredicate inPredicate, Map<Expression, Set<Expression>> context) { + if (!validInPredicate(inPredicate)) { + return null; + } + for (Expression expr : getAllSubExpressions(inPredicate.getCompareExpr())) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(inPredicate); + } + return null; + } + + @Override + public Void visitComparisonPredicate(ComparisonPredicate comparisonPredicate, + Map<Expression, Set<Expression>> context) { + if (!validComparisonPredicate(comparisonPredicate)) { + return null; + } + // It is believed that 1<a has been rewritten as a>1 + for (Expression expr : getAllSubExpressions(comparisonPredicate.child(0))) { + context.computeIfAbsent(expr, k -> new LinkedHashSet<>()).add(comparisonPredicate); + } + return null; + } + + @Override Review Comment: currently !=, don't open not in/not like -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org