zhangstar333 commented on code in PR #40945: URL: https://github.com/apache/doris/pull/40945#discussion_r1768005984
########## be/src/vec/aggregate_functions/aggregate_function_statistic.h: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once +#include <cmath> +#include <cstdint> +#include <string> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "moments.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/aggregate_functions/moments.h" +#include "vec/columns/column_nullable.h" +#include "vec/columns/column_vector.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_nullable.h" +#include "vec/data_types/data_type_number.h" + +namespace doris::vectorized { + +enum class StatisticsFunctionKind : uint8_t { skewPop, kurtPop }; + +inline std::string to_string(StatisticsFunctionKind kind) { + switch (kind) { + case StatisticsFunctionKind::skewPop: + return "skewness"; + case StatisticsFunctionKind::kurtPop: + return "kurtosis"; + default: + return "Unknown"; + } +} + +template <typename T, std::size_t _level> +struct StatFuncOneArg { + using Type1 = T; + using Type2 = T; + using ResultType = Float64; + using Data = VarMoments<ResultType, _level>; + + static constexpr UInt32 num_args = 1; +}; + +template <typename StatFunc, bool NullableInput> +class AggregateFunctionVarianceSimple + : public IAggregateFunctionDataHelper< + typename StatFunc::Data, + AggregateFunctionVarianceSimple<StatFunc, NullableInput>> { +public: + using T1 = typename StatFunc::Type1; + using T2 = typename StatFunc::Type2; + using ColVecT1 = ColumnVectorOrDecimal<T1>; + using ColVecT2 = ColumnVectorOrDecimal<T2>; + using ResultType = typename StatFunc::ResultType; + using ColVecResult = ColumnVector<ResultType>; Review Comment: here seems could write more simple code, as the two function return type is ColumnFloat64 ########## be/src/vec/aggregate_functions/aggregate_function_statistic.h: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once +#include <cmath> +#include <cstdint> +#include <string> +#include <type_traits> + +#include "common/exception.h" +#include "common/status.h" +#include "moments.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/aggregate_functions/moments.h" +#include "vec/columns/column_nullable.h" +#include "vec/columns/column_vector.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_nullable.h" +#include "vec/data_types/data_type_number.h" + +namespace doris::vectorized { + +enum class StatisticsFunctionKind : uint8_t { skewPop, kurtPop }; + +inline std::string to_string(StatisticsFunctionKind kind) { + switch (kind) { + case StatisticsFunctionKind::skewPop: + return "skewness"; + case StatisticsFunctionKind::kurtPop: + return "kurtosis"; + default: + return "Unknown"; + } +} + +template <typename T, std::size_t _level> +struct StatFuncOneArg { + using Type1 = T; + using Type2 = T; + using ResultType = Float64; + using Data = VarMoments<ResultType, _level>; + + static constexpr UInt32 num_args = 1; Review Comment: seems not use this var? ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Kurt.java: ########## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.agg; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.AlwaysNullable; +import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature; +import org.apache.doris.nereids.trees.expressions.shape.UnaryExpression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.BigIntType; +import org.apache.doris.nereids.types.DoubleType; +import org.apache.doris.nereids.types.FloatType; +import org.apache.doris.nereids.types.IntegerType; +import org.apache.doris.nereids.types.LargeIntType; +import org.apache.doris.nereids.types.SmallIntType; +import org.apache.doris.nereids.types.TinyIntType; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * AggregateFunction 'Kurt'. + */ +public class Kurt extends AggregateFunction + implements UnaryExpression, ExplicitlyCastableSignature, AlwaysNullable { + + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.ret(DoubleType.INSTANCE).args(FloatType.INSTANCE), Review Comment: could let FE members check the args order, https://github.com/apache/doris/pull/39352 ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Skew.java: ########## @@ -0,0 +1,82 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.agg; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.AlwaysNullable; +import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature; +import org.apache.doris.nereids.trees.expressions.shape.UnaryExpression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.BigIntType; +import org.apache.doris.nereids.types.DoubleType; +import org.apache.doris.nereids.types.FloatType; +import org.apache.doris.nereids.types.IntegerType; +import org.apache.doris.nereids.types.LargeIntType; +import org.apache.doris.nereids.types.SmallIntType; +import org.apache.doris.nereids.types.TinyIntType; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * AggregateFunction 'Skew'. + */ + +public class Skew extends AggregateFunction + implements UnaryExpression, ExplicitlyCastableSignature, AlwaysNullable { + + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.ret(DoubleType.INSTANCE).args(FloatType.INSTANCE), + FunctionSignature.ret(DoubleType.INSTANCE).args(DoubleType.INSTANCE), Review Comment: and here ########## be/src/vec/aggregate_functions/moments.h: ########## @@ -0,0 +1,112 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <stddef.h> + +#include "common/exception.h" +#include "common/status.h" +#include "vec/io/io_helper.h" + +namespace doris::vectorized { + +class BufferReadable; +class BufferWritable; + +template <typename T, size_t _level> +struct VarMoments { + // m[1] = sum(x) + // m[2] = sum(x^2) + // m[3] = sum(x^3) + // m[4] = sum(x^4) + T m[_level + 1] {}; + + void add(T x) { + ++m[0]; + m[1] += x; + m[2] += x * x; + if constexpr (_level >= 3) m[3] += x * x * x; + if constexpr (_level >= 4) m[4] += x * x * x * x; + } + + void merge(const VarMoments& rhs) { + m[0] += rhs.m[0]; + m[1] += rhs.m[1]; + m[2] += rhs.m[2]; + if constexpr (_level >= 3) m[3] += rhs.m[3]; + if constexpr (_level >= 4) m[4] += rhs.m[4]; + } + + void write(BufferWritable& buf) const { write_binary(*this, buf); } + + void read(BufferReadable& buf) { read_binary(*this, buf); } + + T get() const { + throw doris::Exception(ErrorCode::INTERNAL_ERROR, + "Variation moments should be obtained by either 'getSample' or " + "'getPopulation' method"); + } + + T getPopulation() const { + if (m[0] == 0) return std::numeric_limits<T>::quiet_NaN(); + + /// Due to numerical errors, the result can be slightly less than zero, + /// but it should be impossible. Trim to zero. + + return std::max(T {}, (m[2] - m[1] * m[1] / m[0]) / m[0]); + } + + T getSample() const { + if (m[0] <= 1) return std::numeric_limits<T>::quiet_NaN(); + return std::max(T {}, (m[2] - m[1] * m[1] / m[0]) / (m[0] - 1)); + } + + T getMoment3() const { + if constexpr (_level < 3) { + throw doris::Exception(ErrorCode::INTERNAL_ERROR, + "Variation moments should be obtained by either 'getSample' or " + "'getPopulation' method"); + } else { + if (m[0] == 0) return std::numeric_limits<T>::quiet_NaN(); + // to avoid accuracy problem + if (m[0] == 1) return 0; + /// \[ \frac{1}{m_0} (m_3 - (3 * m_2 - \frac{2 * {m_1}^2}{m_0}) * \frac{m_1}{m_0});\] + return (m[3] - (3 * m[2] - 2 * m[1] * m[1] / m[0]) * m[1] / m[0]) / m[0]; + } + } + + T getMoment4() const { + if constexpr (_level < 4) { + throw doris::Exception(ErrorCode::INTERNAL_ERROR, + "Variation moments should be obtained by either 'getSample' or " + "'getPopulation' method"); + } else { + if (m[0] == 0) return std::numeric_limits<T>::quiet_NaN(); + // to avoid accuracy problem + if (m[0] == 1) return 0; + /// \[ \frac{1}{m_0}(m_4 - (4 * m_3 - (6 * m_2 - \frac{3 * m_1^2}{m_0} ) \frac{m_1}{m_0})\frac{m_1}{m_0})\] + return (m[4] - + (4 * m[3] - (6 * m[2] - 3 * m[1] * m[1] / m[0]) * m[1] / m[0]) * m[1] / m[0]) / + m[0]; + } + } + + void reset() { return; } Review Comment: this function is usefully, should reset all m to init val -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
