yiguolei commented on code in PR #9005:
URL: https://github.com/apache/incubator-doris/pull/9005#discussion_r851573765
##########
fe/fe-core/src/main/java/org/apache/doris/master/ReportHandler.java:
##########
@@ -665,67 +662,42 @@ private static void deleteFromMeta(ListMultimap<Long,
Long> tabletDeleteFromMeta
}
private static void deleteFromBackend(Map<Long, TTablet> backendTablets,
- Set<Long>
foundTabletsWithValidSchema,
- Map<Long, TTabletInfo>
foundTabletsWithInvalidSchema,
+ Set<Long> tabletFoundInMeta,
long backendId) {
int deleteFromBackendCounter = 0;
int addToMetaCounter = 0;
AgentBatchTask batchTask = new AgentBatchTask();
- // This means that the meta of all backend tablets can be found in fe,
we only need to process tablets with invalid Schema
- if (foundTabletsWithValidSchema.size() +
foundTabletsWithInvalidSchema.size() == backendTablets.size()) {
- for (Long tabletId : foundTabletsWithInvalidSchema.keySet()) {
- // this tablet is found in meta but with invalid schema hash.
delete it.
- int schemaHash =
foundTabletsWithInvalidSchema.get(tabletId).getSchemaHash();
- DropReplicaTask task = new DropReplicaTask(backendId,
tabletId, schemaHash);
+ for (Long tabletId : backendTablets.keySet()) {
+ TTablet backendTablet = backendTablets.get(tabletId);
+ TTabletInfo backendTabletInfo =
backendTablet.getTabletInfos().get(0);
+ boolean needDelete = false;
Review Comment:
If tablet is not find in tablet meta, then the tablet is not deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
