[incubator-doris] branch stream-load-vec updated: [Fix bug] fix replace table vec-stream-load coredump (#9001)

[yiguolei]

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch stream-load-vec
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/stream-load-vec by this push:
     new 4d4bb906f1 [Fix bug] fix replace table vec-stream-load coredump (#9001)
4d4bb906f1 is described below

commit 4d4bb906f1562ab58a0f1d0c69e6c7eca7681b3b
Author: zbtzbtzbt <35688959+zbtzbt...@users.noreply.github.com>
AuthorDate: Fri Apr 15 11:26:32 2022 +0800

    [Fix bug] fix replace table vec-stream-load coredump (#9001)
---
 be/src/olap/memtable.h                                       | 6 ++----
 be/src/vec/aggregate_functions/aggregate_function_window.cpp | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/be/src/olap/memtable.h b/be/src/olap/memtable.h
index ef41319b6b..02f7699719 100644
--- a/be/src/olap/memtable.h
+++ b/be/src/olap/memtable.h
@@ -103,10 +103,8 @@ private:
             NullState null_state = is_null ? NullState::IS_NULL : 
NullState::NOT_NULL;
             return RowCursorCell(ref.data, null_state);
         }
-        ~ RowInBlock(){
-            for( auto place: _agg_places){
-                delete place;
-            }
+        ~RowInBlock() {
+            std::vector<vectorized::AggregateDataPtr>().swap(_agg_places);
         }
     };
     class RowInBlockComparator {
diff --git a/be/src/vec/aggregate_functions/aggregate_function_window.cpp 
b/be/src/vec/aggregate_functions/aggregate_function_window.cpp
index b96f241e51..d4b7f99121 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_window.cpp
+++ b/be/src/vec/aggregate_functions/aggregate_function_window.cpp
@@ -58,7 +58,7 @@ template <template <typename> class 
AggregateFunctionTemplate, template <typenam
 static IAggregateFunction* create_function_single_value(const String& name,
                                                         const DataTypes& 
argument_types,
                                                         const Array& 
parameters) {
-    using StoreType = std::conditional_t<is_copy, CopiedValue, Value>;
+    using StoreType = CopiedValue;
 
     assert_arity_at_most<3>(name, argument_types);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org