EmmyMiao87 commented on code in PR #8947: URL: https://github.com/apache/incubator-doris/pull/8947#discussion_r850051996
########## fe/fe-core/src/main/java/org/apache/doris/statistics/StatsRecursiveDerive.java: ########## @@ -0,0 +1,57 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.statistics; + +import org.apache.doris.planner.PlanNode; + +import java.util.HashMap; +import java.util.Map; + + +public class StatsRecursiveDerive { + Map<PlanNode.NodeType, BaseStatsDerive> typeToDerive = new HashMap<>(); Review Comment: private ########## fe/fe-core/src/main/java/org/apache/doris/statistics/StatsRecursiveDerive.java: ########## @@ -0,0 +1,57 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.statistics; + +import org.apache.doris.planner.PlanNode; + +import java.util.HashMap; +import java.util.Map; + + +public class StatsRecursiveDerive { + Map<PlanNode.NodeType, BaseStatsDerive> typeToDerive = new HashMap<>(); + + /** + * Recursively complete the derivation of statistics for this node and all its children + * @param node + * This parameter is an input and output parameter, + * which will store the derivation result of statistical information in the corresponding node + */ + public void statsRecursiveDerive(PlanNode node) { + if (node.getStatsDeriveResult().isStatsDerived()) { + return; + } + for (PlanNode childNode : node.getChildren()) { + if (!childNode.getStatsDeriveResult().isStatsDerived()) { + statsRecursiveDerive(childNode); + } + } + + node.setStatsDeriveResult(typeToDerive.get(node.getNodeType()).init(node).deriveStats()); + } + + public void creteNodeTypeToDeriveMap() { + typeToDerive.put(PlanNode.NodeType.DEFAULT, new BaseStatsDerive() { Review Comment: Each nodetype corresponds to a statsderive object. But there are member variables in the statsderive object, and the init function does not reset . Different node instances of the same node type will use the same statsderive object. eventually lead to an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
