github-actions[bot] commented on code in PR #38908:
URL: https://github.com/apache/doris/pull/38908#discussion_r1739965507


##########
be/src/vec/exprs/vexpr.cpp:
##########
@@ -611,80 +611,134 @@ Status VExpr::get_result_from_const(vectorized::Block* 
block, const std::string&
     return Status::OK();
 }
 
-bool VExpr::fast_execute(Block& block, const ColumnNumbers& arguments, size_t 
result,
-                         size_t input_rows_count, const std::string& 
function_name) {
-    if (!_enable_inverted_index_query) {
-        return false;
+Status VExpr::_evaluate_inverted_index(VExprContext* context, const 
FunctionBasePtr& function,

Review Comment:
   warning: function '_evaluate_inverted_index' exceeds recommended 
size/complexity thresholds [readability-function-size]
   ```cpp
   Status VExpr::_evaluate_inverted_index(VExprContext* context, const 
FunctionBasePtr& function,
                 ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/vec/exprs/vexpr.cpp:613:** 106 lines including whitespace and 
comments (threshold 80)
   ```cpp
   Status VExpr::_evaluate_inverted_index(VExprContext* context, const 
FunctionBasePtr& function,
                 ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to