github-actions[bot] commented on code in PR #40168:
URL: https://github.com/apache/doris/pull/40168#discussion_r1737852814
##########
be/src/olap/rowset/segment_v2/column_writer.cpp:
##########
@@ -534,7 +534,8 @@ Status ScalarColumnWriter::append_data(const uint8_t** ptr,
size_t num_rows) {
return Status::OK();
}
-Status ScalarColumnWriter::append_data_in_current_page(const uint8_t* data,
size_t* num_written) {
+Status ScalarColumnWriter::_internal_append_data_in_current_page(const
uint8_t* data,
+ size_t*
num_written) {
Review Comment:
warning: pointer parameter 'num_written' can be pointer to const
[readability-non-const-parameter]
be/src/olap/rowset/segment_v2/column_writer.h:227:
```diff
- Status _internal_append_data_in_current_page(const uint8_t* ptr,
size_t* num_written);
+ Status _internal_append_data_in_current_page(const uint8_t* ptr, const
size_t* num_written);
```
```suggestion
const
size_t* num_written) {
```
##########
be/src/olap/rowset/segment_v2/column_writer.h:
##########
@@ -217,10 +217,16 @@ class ScalarColumnWriter : public ColumnWriter {
// used for append not null data. When page is full, will append data not
reach num_rows.
Status append_data_in_current_page(const uint8_t** ptr, size_t*
num_written);
- Status append_data_in_current_page(const uint8_t* ptr, size_t*
num_written);
+ Status append_data_in_current_page(const uint8_t* ptr, size_t*
num_written) {
+ RETURN_IF_CATCH_EXCEPTION(
+ { return _internal_append_data_in_current_page(ptr,
num_written); });
+ }
friend class ArrayColumnWriter;
friend class OffsetColumnWriter;
+private:
+ Status _internal_append_data_in_current_page(const uint8_t* ptr, size_t*
num_written);
+
private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/column_writer.h:226:** previously declared
here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
