HappenLee commented on code in PR #39354:
URL: https://github.com/apache/doris/pull/39354#discussion_r1737701119
##########
be/src/vec/functions/functions_multi_string_search.cpp:
##########
@@ -206,44 +243,29 @@ struct FunctionMultiMatchAnyImpl {
return Status::OK();
}
- multiregexps::DeferredConstructedRegexpsPtr
deferred_constructed_regexps =
- multiregexps::getOrSet</*SaveIndices*/ FindAnyIndex,
WithEditDistance>(
- needles, std::nullopt);
- multiregexps::Regexps* regexps = deferred_constructed_regexps->get();
-
- hs_scratch_t* scratch = nullptr;
- hs_error_t err = hs_clone_scratch(regexps->getScratch(), &scratch);
-
- if (err != HS_SUCCESS)
- return Status::InternalError("could not clone scratch space for
vectorscan");
+ multiregexps::Regexps* regexps = nullptr;
+ multiregexps::ScratchPtr smart_scratch;
+ Status status = prepare_regexps_and_scratch(needles, regexps,
smart_scratch);
Review Comment:
RETURN_IF_ERROR(prepare_regexps_and_scratch(needles, regexps,
smart_scratch));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
