github-actions[bot] commented on code in PR #40020:
URL: https://github.com/apache/doris/pull/40020#discussion_r1734111277
##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -111,8 +111,8 @@ Status PageIO::write_page(io::FileWriter* writer, const
std::vector<Slice>& body
return Status::OK();
}
-Status PageIO::read_and_decompress_page(const PageReadOptions& opts,
PageHandle* handle,
- Slice* body, PageFooterPB* footer) {
+Status PageIO::read_and_decompress_page_(const PageReadOptions& opts,
PageHandle* handle,
Review Comment:
warning: function 'read_and_decompress_page_' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status PageIO::read_and_decompress_page_(const PageReadOptions& opts,
PageHandle* handle,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/page_io.cpp:113:** 115 lines including
whitespace and comments (threshold 80)
```cpp
Status PageIO::read_and_decompress_page_(const PageReadOptions& opts,
PageHandle* handle,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
