github-actions[bot] commented on code in PR #40010:
URL: https://github.com/apache/doris/pull/40010#discussion_r1733795623
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -693,14 +693,14 @@ Status Segment::new_inverted_index_iterator(const
TabletColumn& tablet_column,
return Status::OK();
}
-Status Segment::lookup_row_key(const Slice& key, bool with_seq_col, bool
with_rowid,
- RowLocation* row_location) {
+Status Segment::lookup_row_key(const Slice& key, const TabletSchema*
latest_schema,
Review Comment:
warning: function 'lookup_row_key' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status Segment::lookup_row_key(const Slice& key, const TabletSchema*
latest_schema,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/segment.cpp:695:** 87 lines including
whitespace and comments (threshold 80)
```cpp
Status Segment::lookup_row_key(const Slice& key, const TabletSchema*
latest_schema,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
