dataroaring commented on code in PR #39756:
URL: https://github.com/apache/doris/pull/39756#discussion_r1732861874
##########
be/src/exec/tablet_info.cpp:
##########
@@ -186,11 +199,42 @@ Status OlapTableSchemaParam::init(const
TOlapTableSchemaParam& tschema) {
_db_id = tschema.db_id;
_table_id = tschema.table_id;
_version = tschema.version;
- _is_partial_update = tschema.is_partial_update;
+ if (tschema.__isset.unique_key_update_mode) {
+ switch (tschema.unique_key_update_mode) {
+ case doris::TUniqueKeyUpdateMode::UPSERT: {
+ _unique_key_update_mode = UniqueKeyUpdateModePB::UPSERT;
+ break;
+ }
+ case doris::TUniqueKeyUpdateMode::UPDATE_FIXED_COLUMNS: {
+ _unique_key_update_mode =
UniqueKeyUpdateModePB::UPDATE_FIXED_COLUMNS;
+ break;
+ }
+ case doris::TUniqueKeyUpdateMode::UPDATE_FLEXIBLE_COLUMNS: {
+ _unique_key_update_mode =
UniqueKeyUpdateModePB::UPDATE_FLEXIBLE_COLUMNS;
+ break;
+ }
+ default: {
+ return Status::InternalError(
+ "Unknown unique_key_update_mode: {}, should be one of "
+ "UPSERT/UPDATE_FIXED_COLUMNS/UPDATE_FLEXIBLE_COLUMNS",
+ tschema.unique_key_update_mode);
+ }
+ }
+ if (tschema.__isset.sequence_map_col_unique_id) {
+ _sequence_map_col_uid = tschema.sequence_map_col_unique_id;
+ }
+ } else {
+ // for backward compatibility
+ if (tschema.__isset.is_partial_update && tschema.is_partial_update) {
+ _unique_key_update_mode =
UniqueKeyUpdateModePB::UPDATE_FIXED_COLUMNS;
+ } else {
+ _unique_key_update_mode = UniqueKeyUpdateModePB::UPSERT;
+ }
+ }
Review Comment:
put into a new function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
