github-actions[bot] commented on code in PR #38908:
URL: https://github.com/apache/doris/pull/38908#discussion_r1732606927
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -53,76 +54,107 @@ class VCompoundPred : public VectorizedFnCall {
const std::string& expr_name() const override { return _expr_name; }
- // 1. when meet 'or' conjunct: a or b, if b can apply index, return all
rows, so b should not be extracted
- // 2. when meet 'and' conjunct, function with column b can not apply
inverted index
- // eg. a and hash(b)=1, if b can apply index, but hash(b)=1 is not
for index, so b should not be extracted
- // but a and array_contains(b, 1), b can be applied inverted
index, which b can be extracted
- Status eval_inverted_index(
- VExprContext* context,
- const std::unordered_map<ColumnId,
std::pair<vectorized::IndexFieldNameAndTypePair,
-
segment_v2::InvertedIndexIterator*>>&
- colid_to_inverted_index_iter,
- uint32_t num_rows, roaring::Roaring* bitmap) const override {
- std::shared_ptr<roaring::Roaring> res =
std::make_shared<roaring::Roaring>();
- if (_op == TExprOpcode::COMPOUND_OR) {
- for (auto child : _children) {
- std::shared_ptr<roaring::Roaring> child_roaring =
- std::make_shared<roaring::Roaring>();
- Status st = child->eval_inverted_index(context,
colid_to_inverted_index_iter,
- num_rows,
child_roaring.get());
- if (!st.ok()) {
- bitmap->addRange(0, num_rows);
- return st;
+ Status evaluate_inverted_index(VExprContext* context, uint32_t
segment_num_rows) override {
Review Comment:
warning: function 'evaluate_inverted_index' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status evaluate_inverted_index(VExprContext* context, uint32_t
segment_num_rows) override {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exprs/vcompound_pred.h:56:** 95 lines including whitespace and
comments (threshold 80)
```cpp
Status evaluate_inverted_index(VExprContext* context, uint32_t
segment_num_rows) override {
^
```
</details>
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -53,76 +54,107 @@
const std::string& expr_name() const override { return _expr_name; }
- // 1. when meet 'or' conjunct: a or b, if b can apply index, return all
rows, so b should not be extracted
- // 2. when meet 'and' conjunct, function with column b can not apply
inverted index
- // eg. a and hash(b)=1, if b can apply index, but hash(b)=1 is not
for index, so b should not be extracted
- // but a and array_contains(b, 1), b can be applied inverted
index, which b can be extracted
- Status eval_inverted_index(
- VExprContext* context,
- const std::unordered_map<ColumnId,
std::pair<vectorized::IndexFieldNameAndTypePair,
-
segment_v2::InvertedIndexIterator*>>&
- colid_to_inverted_index_iter,
- uint32_t num_rows, roaring::Roaring* bitmap) const override {
- std::shared_ptr<roaring::Roaring> res =
std::make_shared<roaring::Roaring>();
- if (_op == TExprOpcode::COMPOUND_OR) {
- for (auto child : _children) {
- std::shared_ptr<roaring::Roaring> child_roaring =
- std::make_shared<roaring::Roaring>();
- Status st = child->eval_inverted_index(context,
colid_to_inverted_index_iter,
- num_rows,
child_roaring.get());
- if (!st.ok()) {
- bitmap->addRange(0, num_rows);
- return st;
+ Status evaluate_inverted_index(VExprContext* context, uint32_t
segment_num_rows) override {
+ segment_v2::InvertedIndexResultBitmap res;
+ bool all_pass = true;
+
+ switch (_op) {
+ case TExprOpcode::COMPOUND_OR: {
+ for (const auto& child : _children) {
+ if (Status st = child->evaluate_inverted_index(context,
segment_num_rows);
+ !st.ok()) {
+ LOG(ERROR) << "expr:" << child->expr_name()
+ << " evaluate_inverted_index error:" <<
st.to_string();
+ all_pass = false;
+ continue;
}
- if (child_roaring->cardinality() == 0) {
- // means inverted index filter do not reduce any rows
- // the left expr no need to be extracted by inverted index,
- // and cur roaring is all rows which means this inverted
index is not useful,
- // do not need to calculate with res bitmap
- bitmap->addRange(0, num_rows);
- return Status::OK();
+ if
(context->get_inverted_index_context()->has_inverted_index_result_for_expr(
+ child.get())) {
+ const auto* index_result =
+ context->get_inverted_index_context()
+
->get_inverted_index_result_for_expr(child.get());
+ if (res.is_empty()) {
+ res = *index_result;
+ } else {
+ res |= *index_result;
+ }
+ if (res.get_data_bitmap()->cardinality() ==
segment_num_rows) {
+ break; // Early exit if result is full
+ }
+ } else {
+ all_pass = false;
}
- *res |= *child_roaring;
}
- *bitmap = *res;
- } else if (_op == TExprOpcode::COMPOUND_AND) {
- for (int i = 0; i < _children.size(); ++i) {
- std::shared_ptr<roaring::Roaring> child_roaring =
- std::make_shared<roaring::Roaring>();
- Status st = _children[0]->eval_inverted_index(context,
colid_to_inverted_index_iter,
- num_rows,
child_roaring.get());
- if (!st.ok()) {
+ break;
+ }
+ case TExprOpcode::COMPOUND_AND: {
+ for (const auto& child : _children) {
+ if (Status st = child->evaluate_inverted_index(context,
segment_num_rows);
+ !st.ok()) {
+ LOG(ERROR) << "expr:" << child->expr_name()
+ << " evaluate_inverted_index error:" <<
st.to_string();
+ all_pass = false;
continue;
}
- if (i == 0) {
- *res = *child_roaring;
+ if
(context->get_inverted_index_context()->has_inverted_index_result_for_expr(
+ child.get())) {
+ const auto* index_result =
+ context->get_inverted_index_context()
+
->get_inverted_index_result_for_expr(child.get());
+ if (res.is_empty()) {
+ res = *index_result;
+ } else {
+ res &= *index_result;
+ }
+
+ if (res.get_data_bitmap()->isEmpty()) {
+ break; // Early exit if result is empty
+ }
} else {
- *res &= *child_roaring;
- }
- if (res->isEmpty()) {
- // the left expr no need to be extracted by inverted
index, just return 0 rows
- // res bitmap will be zero
- return Status::OK();
+ all_pass = false;
}
}
- *bitmap = *res;
- } else if (_op == TExprOpcode::COMPOUND_NOT) {
- Status st = _children[0]->eval_inverted_index(context,
colid_to_inverted_index_iter,
- num_rows, res.get());
+ break;
+ }
+ case TExprOpcode::COMPOUND_NOT: {
+ const auto& child = _children[0];
+ Status st = child->evaluate_inverted_index(context,
segment_num_rows);
if (!st.ok()) {
+ LOG(ERROR) << "expr:" << child->expr_name()
+ << " evaluate_inverted_index error:" <<
st.to_string();
return st;
}
- std::shared_ptr<roaring::Roaring> all_rows =
std::make_shared<roaring::Roaring>();
- all_rows->addRange(0, num_rows);
- *bitmap = *all_rows - *res;
- } else {
+
+ if
(context->get_inverted_index_context()->has_inverted_index_result_for_expr(
+ child.get())) {
+ const auto* index_result =
+
context->get_inverted_index_context()->get_inverted_index_result_for_expr(
+ child.get());
+ roaring::Roaring full_result;
+ full_result.addRange(0, segment_num_rows);
+ res = index_result->op_not(&full_result);
+ } else {
+ all_pass = false;
+ }
+ break;
+ }
+ default:
return Status::NotSupported(
- "Compound operator must be AND or OR or Not can execute
with inverted index.");
+ "Compound operator must be AND, OR, or NOT to execute with
inverted index.");
+ }
+
+ if (all_pass && !res.is_empty()) {
+ // set fast_execute when expr evaluated by inverted index correctly
+ _can_fast_execute = true;
+
context->get_inverted_index_context()->set_inverted_index_result_for_expr(this,
res);
}
return Status::OK();
}
Status execute(VExprContext* context, Block* block, int* result_column_id)
override {
Review Comment:
warning: function 'execute' has cognitive complexity of 112 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status execute(VExprContext* context, Block* block, int*
result_column_id) override {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exprs/vcompound_pred.h:154:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_can_fast_execute && fast_execute(context, block,
result_column_id)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:154:** +1
```cpp
if (_can_fast_execute && fast_execute(context, block,
result_column_id)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:157:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (children().size() == 1 ||
!_all_child_is_compound_and_not_const()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:163:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_children[0]->execute(context, block, &lhs_id));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:163:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_children[0]->execute(context, block, &lhs_id));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:175:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (lhs_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:189:** nesting level increased to 1
```cpp
auto get_rhs_colum = [&]() {
^
```
**be/src/vec/exprs/vcompound_pred.h:190:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (rhs_id == -1) {
^
```
**be/src/vec/exprs/vcompound_pred.h:191:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_children[1]->execute(context, block,
&rhs_id));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:191:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_children[1]->execute(context, block,
&rhs_id));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:201:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if (rhs_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:209:** nesting level increased to 1
```cpp
auto return_result_column_id = [&](ColumnPtr res_column, int res_id)
-> int {
^
```
**be/src/vec/exprs/vcompound_pred.h:210:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (result_is_nullable && !res_column->is_nullable()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:210:** +1
```cpp
if (result_is_nullable && !res_column->is_nullable()) {
^
```
**be/src/vec/exprs/vcompound_pred.h:219:** nesting level increased to 1
```cpp
auto create_null_map_column = [&](ColumnPtr& null_map_column,
^
```
**be/src/vec/exprs/vcompound_pred.h:221:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (null_map_data == nullptr) {
^
```
**be/src/vec/exprs/vcompound_pred.h:230:** nesting level increased to 1
```cpp
auto vector_vector_null = [&]<bool is_and_op>() {
^
```
**be/src/vec/exprs/vcompound_pred.h:240:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if constexpr (is_and_op) {
^
```
**be/src/vec/exprs/vcompound_pred.h:241:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
for (size_t i = 0; i < size; ++i) {
^
```
**be/src/vec/exprs/vcompound_pred.h:246:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:247:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
for (size_t i = 0; i < size; ++i) {
^
```
**be/src/vec/exprs/vcompound_pred.h:260:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_op == TExprOpcode::COMPOUND_AND) {
^
```
**be/src/vec/exprs/vcompound_pred.h:263:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:263:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:263:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:263:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:266:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:267:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:267:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:269:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if ((lhs_all_true && !lhs_is_nullable) || //not null
column
^
```
**be/src/vec/exprs/vcompound_pred.h:269:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || //not null
column
^
```
**be/src/vec/exprs/vcompound_pred.h:269:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || //not null
column
^
```
**be/src/vec/exprs/vcompound_pred.h:270:** +1
```cpp
(lhs_all_true && lhs_all_is_not_null)) { //nullable
column
^
```
**be/src/vec/exprs/vcompound_pred.h:273:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:273:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:273:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:274:** +1
```cpp
(rhs_all_false && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:277:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:277:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:277:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:278:** +1
```cpp
(rhs_all_true && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:281:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:282:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
if (!result_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:284:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
for (size_t i = 0; i < size; i++) {
^
```
**be/src/vec/exprs/vcompound_pred.h:287:** +1, nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:292:** +1, nesting level increased to 1
```cpp
} else if (_op == TExprOpcode::COMPOUND_OR) {
^
```
**be/src/vec/exprs/vcompound_pred.h:295:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:295:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:295:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:295:** +1
```cpp
if ((lhs_all_true && !lhs_is_nullable) || (lhs_all_true &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:298:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:299:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exprs/vcompound_pred.h:299:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(get_rhs_colum());
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exprs/vcompound_pred.h:300:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:300:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:300:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:300:** +1
```cpp
if ((lhs_all_false && !lhs_is_nullable) || (lhs_all_false &&
lhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:303:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:303:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:303:** +1
```cpp
} else if ((rhs_all_true && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:304:** +1
```cpp
(rhs_all_true && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:307:** +1, nesting level increased to 3
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:307:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:307:** +1
```cpp
} else if ((rhs_all_false && !rhs_is_nullable) ||
^
```
**be/src/vec/exprs/vcompound_pred.h:308:** +1
```cpp
(rhs_all_false && rhs_all_is_not_null)) {
^
```
**be/src/vec/exprs/vcompound_pred.h:311:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:312:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
if (!result_is_nullable) {
^
```
**be/src/vec/exprs/vcompound_pred.h:314:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
for (size_t i = 0; i < size; i++) {
^
```
**be/src/vec/exprs/vcompound_pred.h:317:** +1, nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/exprs/vcompound_pred.h:322:** +1, nesting level increased to 1
```cpp
} else {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
