github-actions[bot] commented on code in PR #39985:
URL: https://github.com/apache/doris/pull/39985#discussion_r1732482697
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -725,8 +724,7 @@
// used by shuffle runtime filter
// assign this filter by protobuf
- Status assign(const PMinMaxFilter* minmax_filter, bool contain_null) {
- PrimitiveType type = to_primitive_type(minmax_filter->column_type());
+ Status assign(const PMinMaxFilter* minmax_filter, bool contain_null,
PrimitiveType type) {
Review Comment:
warning: function 'assign' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status assign(const PMinMaxFilter* minmax_filter, bool contain_null,
PrimitiveType type) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exprs/runtime_filter.cpp:726:** 128 lines including whitespace and
comments (threshold 80)
```cpp
Status assign(const PMinMaxFilter* minmax_filter, bool contain_null,
PrimitiveType type) {
^
```
</details>
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -553,8 +553,7 @@ class RuntimePredicateWrapper {
return Status::OK();
}
- Status assign(const PInFilter* in_filter, bool contain_null) {
- PrimitiveType type = to_primitive_type(in_filter->column_type());
+ Status assign(const PInFilter* in_filter, bool contain_null, PrimitiveType
type) {
Review Comment:
warning: function 'assign' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status assign(const PInFilter* in_filter, bool contain_null,
PrimitiveType type) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exprs/runtime_filter.cpp:555:** 153 lines including whitespace and
comments (threshold 80)
```cpp
Status assign(const PInFilter* in_filter, bool contain_null,
PrimitiveType type) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
